Open
Conversation
jarbesfeld
reviewed
Jul 17, 2024
| def num_vowels(text): | ||
| """Return the number of vowels in string.""" | ||
| vowels = "aeiou" | ||
| vowels = "aeiouy" |
Owner
There was a problem hiding this comment.
y is both a consonant and value, so the definition of vowel should be clarified
jarbesfeld
reviewed
Jul 17, 2024
| num += text.lower().count(v) | ||
| return num | ||
|
|
||
| def num_consonants(text): |
Owner
There was a problem hiding this comment.
Docstrings could be added to describe what the function is doing
jarbesfeld
reviewed
Jul 17, 2024
| for letter in text: | ||
| if letter not in vowels: | ||
| print("consonant", letter) | ||
| num += text.lower().count(letter) |
Owner
There was a problem hiding this comment.
What about numbers? I don't think numbers should be counted as consonants, but they were counted when I tested the script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added some comments explaining the code.
Fixed the consonant printing.
Improved the message that is printed out.
Tested with the following strings:
Fixes issue
Fixes #7 python